Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry logic for chat engagement #1056

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Retry logic for chat engagement #1056

merged 1 commit into from
Sep 30, 2024

Conversation

EgorovEI
Copy link
Contributor

MOB-3597

What was solved?
This PR adds retry logic for regular chat engagement:

  • marking failed messages;
  • tap actions for undelivered messages;
  • replacement logic after successful retry;
  • extends Outgoing message model with relation property to keep association with response cards;

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

@EgorovEI
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the feature/MOB-3597-send-message-retry-logic branch from fd836eb to 1d1c18d Compare September 30, 2024 10:44
igorkravchenko
igorkravchenko reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to create a ticket for unit tests, since new logic is introduced in the PR.

...Widgets/SecureConversations/ChatTranscript/SecureConversations.ChatWithTranscriptModel.swift Show resolved Hide resolved
GliaWidgets/Sources/ViewModel/Chat/ChatViewModel.swift Show resolved Hide resolved
GliaWidgets/Sources/ViewModel/Chat/Data/OutgoingMessage.swift Show resolved Hide resolved
@EgorovEI
Copy link
Contributor Author

!squash

Retry logic for chat engagement
db7fc2d 
This commit adds retry logic for regular chat engagement:
- marking failed messages;
- tap actions for undelivered messages;
- replacement logic after successful retry;
- extends Outgoing message model with `relation` property to keep association with response cards;

MOB-3597
@sm-deployer sm-deployer force-pushed the feature/MOB-3597-send-message-retry-logic branch from cc591a6 to db7fc2d Compare September 30, 2024 12:37
@EgorovEI EgorovEI merged commit a0e31a4 into development Sep 30, 2024
8 checks passed
@EgorovEI EgorovEI deleted the feature/MOB-3597-send-message-retry-logic branch September 30, 2024 12:56
@EgorovEI EgorovEI restored the feature/MOB-3597-send-message-retry-logic branch September 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorovEI @igorkravchenko @rasmustautsglia @ykyivskyi-gl